Configure SecretsResolver in RPM#22991
Merged
Praveen2112 merged 1 commit intotrinodb:masterfrom Aug 9, 2024
Merged
Conversation
wendigo
approved these changes
Aug 9, 2024
nineinchnick
approved these changes
Aug 9, 2024
kokosing
reviewed
Aug 9, 2024
| @@ -176,6 +176,7 @@ public void testRpmContents() | |||
| assertThatPaths(files) | |||
Member
There was a problem hiding this comment.
Can we have similar test for DockerIT?
Member
Author
There was a problem hiding this comment.
We could have something similar to it
Member
Author
There was a problem hiding this comment.
DockerIT test is not available but we could work on something similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates our RPM build to use SecretsResolver
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: