Skip to content

Add StageTaskStatistics#getSplitDistribution #22990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Aug 9, 2024
Merged

Add StageTaskStatistics#getSplitDistribution #22990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion core/trino-main/src/main/java/io/trino/event/QueryMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,7 @@ private StageTaskStatistics computeStageTaskStatistics(QueryInfo queryInfo, Stag
lastEndTimeScaledDistribution = DoubleSymmetricDistribution.ZERO;
endTimeScaledDistribution = DoubleSymmetricDistribution.ZERO;
}
DistributionSnapshot getSplitDistribution = stageInfo.getStageStats().getGetSplitDistribution();
return new StageTaskStatistics(
stageInfo.getStageId().getId(),
stageInfo.getTasks().size(),
Expand All @@ -849,7 +850,21 @@ private StageTaskStatistics computeStageTaskStatistics(QueryInfo queryInfo, Stag
lastStartTimeScaledDistribution,
terminatingStartTimeScaledDistribution,
lastEndTimeScaledDistribution,
endTimeScaledDistribution);
endTimeScaledDistribution,
new DoubleSymmetricDistribution(
getSplitDistribution.getP01(),
getSplitDistribution.getP05(),
getSplitDistribution.getP10(),
getSplitDistribution.getP25(),
getSplitDistribution.getP50(),
getSplitDistribution.getP75(),
getSplitDistribution.getP90(),
getSplitDistribution.getP95(),
getSplitDistribution.getP99(),
getSplitDistribution.getMin(),
getSplitDistribution.getMax(),
getSplitDistribution.getTotal(),
getSplitDistribution.getCount()));
}

private static LongDistribution getTasksDistribution(StageInfo stageInfo, Function<TaskInfo, Optional<Long>> metricFunction)
Expand Down
13 changes: 12 additions & 1 deletion core/trino-spi/src/main/java/io/trino/spi/eventlistener/StageTaskStatistics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ public class StageTaskStatistics
private final DoubleSymmetricDistribution lastEndTimeScaledDistribution;
private final DoubleSymmetricDistribution endTimeScaledDistribution;

// split generation stats
private final DoubleSymmetricDistribution getSplitDistribution;

@JsonCreator
@Unstable
public StageTaskStatistics(
Expand Down Expand Up @@ -85,7 +88,8 @@ public StageTaskStatistics(
@JsonProperty("lastStartTimeScaledDistribution") DoubleSymmetricDistribution lastStartTimeScaledDistribution,
@JsonProperty("terminatingStartTimeScaledDistribution") DoubleSymmetricDistribution terminatingStartTimeScaledDistribution,
@JsonProperty("lastEndTimeScaledDistribution") DoubleSymmetricDistribution lastEndTimeScaledDistribution,
@JsonProperty("endTimeScaledDistribution") DoubleSymmetricDistribution endTimeScaledDistribution)
@JsonProperty("endTimeScaledDistribution") DoubleSymmetricDistribution endTimeScaledDistribution,
@JsonProperty("getSplitDistribution") DoubleSymmetricDistribution getSplitDistribution)
{
this.stageId = stageId;
this.tasks = tasks;
Expand All @@ -112,6 +116,7 @@ public StageTaskStatistics(
this.terminatingStartTimeScaledDistribution = requireNonNull(terminatingStartTimeScaledDistribution, "terminatingStartTimeScaledDistribution is null");
this.lastEndTimeScaledDistribution = requireNonNull(lastEndTimeScaledDistribution, "lastEndTimeScaledDistribution is null");
this.endTimeScaledDistribution = requireNonNull(endTimeScaledDistribution, "endTimeScaledDistribution is null");
this.getSplitDistribution = requireNonNull(getSplitDistribution, "getSplitDistribution is null");
}

@JsonProperty
Expand Down Expand Up @@ -263,4 +268,10 @@ public DoubleSymmetricDistribution getEndTimeScaledDistribution()
{
return endTimeScaledDistribution;
}

@JsonProperty
public DoubleSymmetricDistribution getGetSplitDistribution()
{
return getSplitDistribution;
}
}