Add temporary escape hatch to allow unsafe pushdowns#22987
Merged
martint merged 1 commit intotrinodb:masterfrom Aug 14, 2024
Merged
Add temporary escape hatch to allow unsafe pushdowns#22987martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
losipiuk
reviewed
Aug 14, 2024
core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Aug 14, 2024
PR trinodb#21429 fixed an issue that might cause query failures due to aggressive pushdown of expressions that could fail on certain inputs. Unfortunately, it resulted in a regression in use cases that were relying on this behavior (e.g., issue trinodb#22268). A proper fix is not trivial, so we introduce a temporary escape hatch to allow users to restore the old behavior until the final fix is in place.
martint
force-pushed
the
pushdown-allow-unsafe
branch
from
c977080 to
2eb423e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #21429 fixed an issue that might cause query failures due to aggressive pushdown of expressions that could fail on certain inputs.
Unfortunately, it resulted in a regression in use cases that were relying on this behavior (e.g., issue #22268). A proper fix is not trivial, so we introduce a temporary escape hatch to allow users to restore the old behavior until the final fix is in place.
Release notes
(x) Release notes are required, with the following suggested text: