Skip to content

Simplify testJoinDynamicFilteringBlockProbeSide tests #22969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Aug 7, 2024
Merged

Simplify testJoinDynamicFilteringBlockProbeSide tests #22969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestKuduIntegrationDynamicFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,14 @@ public void testJoinDynamicFilteringSingleValue()
@Test
public void testJoinDynamicFilteringBlockProbeSide()
{
// Wait for both build sides to finish before starting the scan of 'lineitem' table (should be very selective given the dynamic filters).
// Wait for both build side to finish before starting the scan of 'lineitem' table (should be very selective given the dynamic filters).
assertDynamicFiltering(
"SELECT l.comment" +
" FROM lineitem l, part p, orders o" +
" WHERE l.orderkey = o.orderkey AND o.comment = 'nstructions sleep furiously among '" +
" AND p.partkey = l.partkey AND p.comment = 'onic deposits'",
" FROM lineitem l, orders o" +
" WHERE l.orderkey = o.orderkey AND o.comment = 'nstructions sleep furiously among '",
withBroadcastJoinNonReordering(),
1,
1);
6,
Comment thread
sopel39 marked this conversation as resolved.
6);
}

private void assertDynamicFiltering(@Language("SQL") String selectQuery, Session session, int expectedRowCount, int expectedProbeInputRowsRead)
Expand Down
11 changes: 5 additions & 6 deletions plugin/trino-memory/src/test/java/io/trino/plugin/memory/TestMemoryConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,15 +282,14 @@ public void testJoinDynamicFilteringImplicitCoercion()
public void testJoinDynamicFilteringBlockProbeSide()
{
for (JoinDistributionType joinDistributionType : JoinDistributionType.values()) {
// Wait for both build sides to finish before starting the scan of 'lineitem' table (should be very selective given the dynamic filters).
// Wait for both build side to finish before starting the scan of 'lineitem' table (should be very selective given the dynamic filters).
assertDynamicFiltering(
"SELECT l.comment" +
" FROM lineitem l, part p, orders o" +
" WHERE l.orderkey = o.orderkey AND o.comment = 'nstructions sleep furiously among '" +
" AND p.partkey = l.partkey AND p.comment = 'onic deposits'",
" FROM lineitem l, orders o" +
" WHERE l.orderkey = o.orderkey AND o.comment = 'nstructions sleep furiously among '",
noJoinReordering(joinDistributionType),
1,
1, PART_COUNT, ORDERS_COUNT);
6,
6, ORDERS_COUNT);
}
}

Expand Down
11 changes: 5 additions & 6 deletions plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoDynamicFiltering.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,14 @@ public void testJoinDynamicFilteringSingleValue()
@Test
public void testJoinDynamicFilteringBlockProbeSide()
{
// Wait for both build sides to finish before starting the scan of 'lineitem' table (should be very selective given the dynamic filters).
// Wait for both build side to finish before starting the scan of 'lineitem' table (should be very selective given the dynamic filters).
assertDynamicFiltering(
"SELECT l.comment" +
" FROM lineitem l, part p, orders o" +
" WHERE l.orderkey = o.orderkey AND o.comment = 'nstructions sleep furiously among '" +
" AND p.partkey = l.partkey AND p.comment = 'onic deposits'",
" FROM lineitem l, orders o" +
" WHERE l.orderkey = o.orderkey AND o.comment = 'nstructions sleep furiously among '",
withBroadcastJoinNonReordering(),
1,
1);
6,
6);
}

private void assertDynamicFiltering(@Language("SQL") String selectQuery, Session session, int expectedRowCount, int... expectedOperatorRowsRead)
Expand Down