Skip to content

Add scope field for Iceberg REST metastore#22961

Merged
ebyhr merged 2 commits intotrinodb:masterfrom
mayankvadariya:mayank/add-additional-config-in-rest-metastore
Aug 14, 2024
Merged

Add scope field for Iceberg REST metastore#22961
ebyhr merged 2 commits intotrinodb:masterfrom
mayankvadariya:mayank/add-additional-config-in-rest-metastore

Conversation

@mayankvadariya
Copy link
Copy Markdown
Contributor

@mayankvadariya mayankvadariya commented Aug 6, 2024

Description

Add scope field to be used while communicating with Iceberg REST catalog server
Fixes #22947

Release notes

(x) Release notes are required, with the following suggested text:

# Iceberg
* Add `iceberg.rest-catalog.oauth2.scope` configuration property for REST catalog. ({issue}`22961`)

@cla-bot cla-bot Bot added the cla-signed label Aug 6, 2024
@github-actions github-actions Bot added docs iceberg Iceberg connector labels Aug 6, 2024
@ebyhr ebyhr self-requested a review August 7, 2024 00:06
@findinpath findinpath requested a review from pajaks August 13, 2024 05:54
@ebyhr ebyhr force-pushed the mayank/add-additional-config-in-rest-metastore branch 2 times, most recently from 18ba689 to 47b1432 Compare August 14, 2024 00:52
@ebyhr ebyhr marked this pull request as ready for review August 14, 2024 00:57
Copy link
Copy Markdown
Member

@anusudarsan anusudarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tests. LGTM!

@mayankvadariya mayankvadariya force-pushed the mayank/add-additional-config-in-rest-metastore branch 3 times, most recently from 4041635 to 11ed763 Compare August 14, 2024 18:28
@ebyhr ebyhr force-pushed the mayank/add-additional-config-in-rest-metastore branch from 11ed763 to 8eae22d Compare August 14, 2024 22:31
@ebyhr ebyhr merged commit 386b8ed into trinodb:master Aug 14, 2024
@github-actions github-actions Bot added this to the 454 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Test iceberg.rest-catalog.oauth2.credential config property with Polaris catalog in Iceberg connector

4 participants