Conversation
Member
|
Could you confirm CI failures? |
Contributor
Author
|
@ebyhr related. Fixing |
wendigo
force-pushed
the
serafin/airlift-257
branch
2 times, most recently
from
340a123 to
5d153cb
Compare
Contributor
Author
|
@ebyhr I've disabled the generation of error pages on the Jetty side. Now we are in full control over the entities that we return to the clients. This is for better alignment with HTTP/2 |
wendigo
force-pushed
the
serafin/airlift-257
branch
2 times, most recently
from
30404db to
72e3b6a
Compare
losipiuk
reviewed
Aug 5, 2024
core/trino-main/src/main/java/io/trino/server/ThrowableMapper.java
Outdated
Show resolved
Hide resolved
Airlift disabled RESPONSE_SET_STATUS_OVER_SEND_ERROR in release 257. sendError is problematic in HTTP/2 because it doesn't allow sending status text along with the status code (there isn't such thing as status line in HTTP/2). Other than that, the error mapping happened in two places: explicitly in the ThrowableMapper and implictly in Jetty where status code and lines were used to generate an error page. After this change, the mapping happens in a single place which makes it explicit. All internal errors are rendered in the body of the response.
wendigo
force-pushed
the
serafin/airlift-257
branch
from
72e3b6a to
e53250d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes requires as now, errors are rendered using jax-rs, rather than by the servlet container (Jetty).
See: https://eclipse-ee4j.github.io/jersey.github.io/apidocs/3.1.1/jersey/org/glassfish/jersey/server/ServerProperties.html#RESPONSE_SET_STATUS_OVER_SEND_ERROR