Skip to content

don't pass serialization lib to coral#22924

Merged
electrum merged 1 commit intotrinodb:masterfrom
OmerRaifler:remove-coral-log
Aug 6, 2024
Merged

don't pass serialization lib to coral#22924
electrum merged 1 commit intotrinodb:masterfrom
OmerRaifler:remove-coral-log

Conversation

@OmerRaifler
Copy link
Copy Markdown
Contributor

Description

Closes #22801

Fix the spammed coral log by not passing the serialization lib to coral.

Additional context and related issues

We noticed a spammed log from the Coral library every time we queried a Hive view:

com.linkedin.coral.common.HiveTable
Failed to get columns using deserializer: java.lang.NoClassDefFoundError: com/linkedin/coral/$internal/org/apache/hadoop/fs/FileSystem

We realized it happens due to a missing dependency which was removed as part of a project to decouple Trino from Hadoop and Hive.

Since we don’t want Coral to use the Hadoop FileSystem code, we decided the best way to solve this is to make the code change.

Link to Slack thread

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 2, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the hive Hive connector label Aug 2, 2024
@OmerRaifler
Copy link
Copy Markdown
Contributor Author

I tested this internally and I can assure that the log is removed :)

@electrum
Copy link
Copy Markdown
Member

electrum commented Aug 2, 2024

Thanks for the confirmation on testing and the great write up on the issue.

@electrum electrum merged commit caa0bbd into trinodb:master Aug 6, 2024
@github-actions github-actions bot added this to the 454 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hive Hive connector

2 participants