Fix username defaulting to user.name property#22903
Merged
Conversation
nineinchnick
approved these changes
Jul 31, 2024
Contributor
Author
|
That's my fault - I've introduced that during refactoring for the reasons unknown to me |
mosabua
approved these changes
Jul 31, 2024
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Looks good. Please make sure to suggest a release notes entry in the description.
wendigo
force-pushed
the
serafin/username-optional
branch
from
ff3f0bb to
bdd2150
Compare
Member
|
Nice .. now CI is happy too ;-) |
electrum
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22901