Skip to content

Prune digests from OperatorInfo#22891

Merged
wendigo merged 2 commits intotrinodb:masterfrom
sopel39:ks/trim
Aug 1, 2024
Merged

Prune digests from OperatorInfo#22891
wendigo merged 2 commits intotrinodb:masterfrom
sopel39:ks/trim

Conversation

@sopel39
Copy link
Copy Markdown
Member

@sopel39 sopel39 commented Jul 31, 2024

Histogram digests can be of considerable size incresing
serialized strucutre size. QueryStats and StageStats are not mergable,
therefore digests can be trimmed from them.

@sopel39 sopel39 added the no-release-notes This pull request does not require release notes entry label Jul 31, 2024
@cla-bot cla-bot bot added the cla-signed label Jul 31, 2024
@sopel39 sopel39 force-pushed the ks/trim branch 2 times, most recently from cd10233 to 25ea5e9 Compare July 31, 2024 14:12
@sopel39 sopel39 changed the title Trim digests from OperatorInfo Prune digests from OperatorInfo Jul 31, 2024
@sopel39 sopel39 requested a review from wendigo July 31, 2024 14:13
Copy link
Copy Markdown
Contributor

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the second commit message "incresing" vs "increasing"

Histogram digests can be of considerable size when serialized.
QueryStats and StageStats are not mergable,
therefore digests can be pruned from them.
@wendigo wendigo merged commit 478126d into trinodb:master Aug 1, 2024
@github-actions github-actions bot added this to the 454 milestone Aug 1, 2024
@sopel39 sopel39 deleted the ks/trim branch August 1, 2024 12:09
@sopel39 sopel39 mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants