Introduce JdbcPageSourceProvider#22872
Closed
chenjian2664 wants to merge 1 commit intotrinodb:masterfrom
chenjian2664:rc_ph_merge
Closed
Introduce JdbcPageSourceProvider#22872chenjian2664 wants to merge 1 commit intotrinodb:masterfrom chenjian2664:rc_ph_merge
chenjian2664 wants to merge 1 commit intotrinodb:masterfrom
chenjian2664:rc_ph_merge
Conversation
Closed
kokosing
reviewed
Jul 30, 2024
Member
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
I am still looking. I just don't want to keep comments hidden so I am posting what I have so far. The proper review will take me more time. So bear with me.
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMergeSink.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Please use composition instead of inheritance here and in other places like that.
chenjian2664
changed the title
Introduce JdbcPageSourceProvider and refactor phoenix5 merge implementation based on it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
#20532
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.