Skip to content

Metastore code cleanup#22866

Merged
electrum merged 8 commits intotrinodb:masterfrom
electrum:metastore
Jul 29, 2024
Merged

Metastore code cleanup#22866
electrum merged 8 commits intotrinodb:masterfrom
electrum:metastore

Conversation

@electrum
Copy link
Copy Markdown
Member

@electrum electrum commented Jul 29, 2024 •
edited
Loading

Release notes

(x) Release notes are required, with the following suggested text:

# Hive connector
* Rename metastore OpenTelemetry attributes from `trino.hive.*` to `trino.metastore.*`. ({issue}`22866`)

# Iceberg connector
* Rename metastore OpenTelemetry attributes from `trino.hive.*` to `trino.metastore.*`. ({issue}`22866`)

# Delta Lake connector
* Rename metastore OpenTelemetry attributes from `trino.hive.*` to `trino.metastore.*`. ({issue}`22866`)

# Hudi connector
* Rename metastore OpenTelemetry attributes from `trino.hive.*` to `trino.metastore.*`. ({issue}`22866`)

@electrum electrum requested a review from dain July 29, 2024 20:18
@cla-bot cla-bot bot added the cla-signed label Jul 29, 2024
@github-actions github-actions bot added delta-lake Delta Lake connector hive Hive connector labels Jul 29, 2024
wendigo
wendigo reviewed Jul 29, 2024
View reviewed changes
lib/trino-metastore/src/main/java/io/trino/metastore/tracing/MetastoreAttributes.java
public static final AttributeKey<Long> SCHEMA_RESPONSE_COUNT = longKey("trino.metastore.response.schema_count");
public static final AttributeKey<String> TABLE = stringKey("trino.table");
public static final AttributeKey<Long> TABLE_RESPONSE_COUNT = longKey("trino.hive.response.table_count");
public static final AttributeKey<Long> TABLE_RESPONSE_COUNT = longKey("trino.metastore.response.table_count");
Copy link
Copy Markdown
Contributor

@wendigo wendigo Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not backward compatible

Copy link
Copy Markdown
Member Author

@electrum electrum Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll update the release notes

@electrum electrum merged commit feaa55f into trinodb:master Jul 29, 2024
@electrum electrum deleted the metastore branch July 29, 2024 22:43
@github-actions github-actions bot added this to the 454 milestone Jul 29, 2024
@colebow colebow mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wendigo wendigo wendigo approved these changes

@dain dain Awaiting requested review from dain

Assignees

No one assigned

Labels

cla-signed delta-lake Delta Lake connector hive Hive connector

Milestone

454

Development

Successfully merging this pull request may close these issues.

2 participants

@electrum @wendigo