Fail if metastore returns duplicate partition names#22864
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Jul 30, 2024
Merged
Fail if metastore returns duplicate partition names#22864sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
sopel39
added
the
no-release-notes
amoghmargoor
approved these changes
Jul 29, 2024
osscm
approved these changes
Jul 29, 2024
electrum
approved these changes
Jul 30, 2024
.../trino-hive/src/main/java/io/trino/plugin/hive/metastore/SemiTransactionalHiveMetastore.java
Outdated
Show resolved
Hide resolved
.../trino-hive/src/main/java/io/trino/plugin/hive/metastore/SemiTransactionalHiveMetastore.java
Outdated
Show resolved
Hide resolved
Returning duplicate partition names could be a correctness error on metastore side, because duplicate names could reference different logical partitions.
sopel39
force-pushed
the
ks/check_duplicates_metastore
branch
from
aff2cc4 to
d97a6de
Compare
wendigo
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning duplicate partition names could be a correctness error on metastore side, because duplicate names could reference different logical partitions.