Improve SQL routine description#22863
Merged
mosabua merged 1 commit intotrinodb:masterfrom Jul 31, 2024
Merged
Conversation
Ordinant
approved these changes
Jul 29, 2024
Member
Ordinant
left a comment
Ordinant
left a comment
There was a problem hiding this comment.
LGTM. If approved by others, I'll use this wording in the Galaxy pages.
wendigo
approved these changes
Jul 30, 2024
electrum
reviewed
Jul 30, 2024
mosabua
force-pushed
the
routine
branch
2 times, most recently
from
18f79a9 to
a6b8d29
Compare
Member
Author
|
@electrum did some more refinement .. I hope this is ok now. |
electrum
approved these changes
Jul 30, 2024
- And overview with links to more details
Member
Author
|
Fyi @Jessie212 .. this will force a rebase on your PR probably |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I hope to work against the assumption of some readers that routines can invoke other SQL statements and are more than simple functions with this addition. The Limitation section already details that but maybe this can help some more.
Additional context and related issues
There are also suggestions to say that a function operates from data from one row, but I think that is actually wrong. For example you could write a JOIN that combines multiple rows and then uses values from the different rows as input value for a function.
I was thinking about using "scalar function" .. but I am not 100% sure.. since I think it could return a JSON construct. Also .. not sure if readers necessary understand without defining it more.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.