Fix translation of special cast+json_parse functions#22844
Merged
martint merged 1 commit intotrinodb:masterfrom Jul 27, 2024
Merged
Fix translation of special cast+json_parse functions#22844martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
mayankvadariya
approved these changes
Jul 26, 2024
wendigo
approved these changes
Jul 26, 2024
These functions need to be resolved via getCoercion()
martint
force-pushed
the
json-parse-coercion
branch
from
c433747 to
90ca612
Compare
Praveen2112
reviewed
Jul 29, 2024
| JSON_STRING_TO_ARRAY_NAME.equals(call.getFunctionName().getName()) || | ||
| JSON_STRING_TO_ROW_NAME.equals(call.getFunctionName().getName())) { | ||
| // These are special functions that currently need to be resolved via getCoercion() -- TODO: fix this | ||
| resolved = plannerContext.getMetadata().getCoercion(builtinFunctionName(call.getFunctionName().getName()), call.getArguments().get(0).getType(), call.getType()); |
Member
There was a problem hiding this comment.
Isn't getCoercion API is a bit tricky - The internal logic which we do to resolving the function - but the API looks like we are applying coercion from one type to another
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions need to be resolved via getCoercion().
Fixes #22840
Release notes
(x) Release notes are required, with the following suggested text: