Improve visibilty for Breaking change warning#22835
Merged
mosabua merged 1 commit intotrinodb:masterfrom Jul 26, 2024
Merged
Conversation
- Found out that users did not realize the meaning - Also found out that users did not realize its a link to more explanation - New approach is the same as in Trino Gateway 10 and onwards
findepi
approved these changes
Jul 26, 2024
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
Can you paste example how this gets rendered in the doc?
Member
Author
|
Added @findepi - note that before it was just the icon so no highlighting color, so it was not clear that it is a link to more info. And the meaning was kinda clear and only hovering over the icon revealed the alt text. Now its glaringly obvious. |
wendigo
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.