Replacing NaN on coordinator to value n/a#22834
Merged
wendigo merged 1 commit intotrinodb:masterfrom Jul 29, 2024
Merged
Conversation
Contributor
|
It looks weird tbh. I think that better option is to display "n/a" instead of NaN |
anilsomisetty
changed the title
Contributor
Author
|
Hey @wendigo, made the change to display n/a instead of NAN, please review 
|
wendigo
approved these changes
Jul 29, 2024
Contributor
|
I've amended the commit message before push. Thanks @anilsomisetty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently on loading coordinator UI initially it shows NaN for some values because those values are still undefined yet this change will check for NaN and would return empty string in it's place making it more understandable that no value is available for those statistics yet.
Cherry pick from prestodb/presto#23285
Currently it shows
After this change it would look like
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: