Skip to content

Normalize name when dropping catalogs#22826

Merged
wendigo merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/core-drop-catalog
Jul 26, 2024
Merged

Normalize name when dropping catalogs#22826
wendigo merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/core-drop-catalog

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jul 26, 2024

Description

The example failure:

trino> CREATE CATALOG "t" USING tpch;
CREATE CATALOG
trino> DROP CATALOG "t";
Query 20240726_123547_00686_j342b failed: Catalog '"t"' not found
io.trino.spi.TrinoException: Catalog '"t"' not found
	at io.trino.connector.CoordinatorDynamicCatalogManager.dropCatalog(CoordinatorDynamicCatalogManager.java:328)
	at io.trino.execution.DropCatalogTask.execute(DropCatalogTask.java:63)
	at io.trino.execution.DropCatalogTask.execute(DropCatalogTask.java:32)
	at io.trino.execution.DataDefinitionExecution.start(DataDefinitionExecution.java:146)
	at io.trino.execution.SqlQueryManager.createQuery(SqlQueryManager.java:272)
	at io.trino.dispatcher.LocalDispatchQuery.startExecution(LocalDispatchQuery.java:145)
	at io.trino.dispatcher.LocalDispatchQuery.lambda$waitForMinimumWorkers$2(LocalDispatchQuery.java:129)
	at io.airlift.concurrent.MoreFutures.lambda$addSuccessCallback$12(MoreFutures.java:570)
	at io.airlift.concurrent.MoreFutures$3.onSuccess(MoreFutures.java:545)
	at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1137)
	at io.trino.$gen.Trino_446____20240726_120529_2.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1570)

Release notes

# General
* Fix some things. ({issue}`issuenumber`)

@ebyhr ebyhr requested review from dain and wendigo July 26, 2024 12:51
@cla-bot cla-bot bot added the cla-signed label Jul 26, 2024
@wendigo wendigo merged commit 1582e86 into trinodb:master Jul 26, 2024
@github-actions github-actions bot added this to the 454 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants