Skip to content

Enable large dynamic filters#22824

Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Dith3r:ke/ldf
Nov 13, 2024
Merged

Enable large dynamic filters#22824
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Dith3r:ke/ldf

Conversation

@Dith3r
Copy link
Copy Markdown
Member

@Dith3r Dith3r commented Jul 26, 2024

Description

Enable large dynamic filters with increased limits.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# General
* Collect larger dynamic filters to improve performance of queries with selective joins. ({issue}`22824`)

@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Aug 29, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Aug 29, 2024

You can configure all that in your deployment. Do you have any evidence or reasoning why we would change the default values @Dith3r ? Specifically why are the new default values better for an average deployment? Or maybe .. are they better for all deployments?

@Dith3r
Copy link
Copy Markdown
Member Author

Dith3r commented Aug 30, 2024

I will provide benchmark results for tpch/tpcds for hive/iceberg.

@github-actions github-actions bot removed the stale label Aug 30, 2024
@sopel39
Copy link
Copy Markdown
Member

sopel39 commented Sep 23, 2024

@Dith3r should we land this?

@Dith3r
Copy link
Copy Markdown
Member Author

Dith3r commented Sep 23, 2024

@Dith3r should we land this?

#23456 this PR needs to land first.

@sopel39
Copy link
Copy Markdown
Member

sopel39 commented Sep 25, 2024

#23456 this PR needs to land first.

It landed now

@raunaqmorarka
Copy link
Copy Markdown
Member

@Dith3r can you rebase and re-run benchmarks ?

@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Oct 16, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 6, 2024

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Nov 6, 2024

Fyi @raunaqmorarka and @martint - added performance filter to this can be taken into account for upcoming work.

Also @Dith3r feel free to reopen (and potentially rebase) if you want to continue to pursue this change.

@raunaqmorarka raunaqmorarka reopened this Nov 12, 2024
@github-actions github-actions bot removed the stale label Nov 12, 2024
@raunaqmorarka raunaqmorarka force-pushed the ke/ldf branch 2 times, most recently from 733aca9 to bc748bb Compare November 13, 2024 12:44
@raunaqmorarka
Copy link
Copy Markdown
Member

Screenshot 2024-11-13 at 10 10 33 PM Screenshot 2024-11-13 at 10 08 33 PM

@raunaqmorarka raunaqmorarka merged commit 17c77ea into trinodb:master Nov 13, 2024
@github-actions github-actions bot added this to the 465 milestone Nov 13, 2024
@sopel39
Copy link
Copy Markdown
Member

sopel39 commented Nov 13, 2024

nice, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants