Add task retries smoke product test #22798
Conversation
Add smoke product test run with task retries, using filesystem based exchange to gaurd from bugs which are not visible in DistributedQueryRunner (e.g. some classpath related problems).
|
Why does this need to be a product test instead of a regular test using the distributed query runner and multiple in-process nodes? |
Regular test did not catch jackson serialization problems introduced with #22722 (then reverted). DQR queries run fine but with product tests we get: on worker with #22722 applied. |
#22797 fixes the problem - but it would be great to have regression test coverage. |
|
I don't think that adding a product test is worth it tbh. I'd prefer to create some test that basically creates a plugin class loader and tests whether you can serialize/deserialize class when you are in the server class loader. |
How would that be different from test which uses DistributedQueryRunner - where serialization works fine for some reason? This PT is extra 2 mins of CI runtime (in a job which is short anyway so does not extend overall CI for PR), so I do not think it is a big deal. |
| FileAttribute<Set<PosixFilePermission>> posixFilePermissions = PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rw-r--r--")); | ||
| Path minioBucketDirectory; | ||
| try { | ||
| minioBucketDirectory = Files.createTempDirectory("test-bucket-contents", posixFilePermissions); |
There was a problem hiding this comment.
Do we need to expose minio data to the host?
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: