Skip to content

Add compatibility note to S3 file system page#22755

Merged
mosabua merged 1 commit intotrinodb:masterfrom
michaeleby1:me/doc-7810
Aug 29, 2024
Merged

Add compatibility note to S3 file system page#22755
mosabua merged 1 commit intotrinodb:masterfrom
michaeleby1:me/doc-7810

Conversation

@michaeleby1
Copy link
Copy Markdown
Contributor

Description

Add same note as #22711 to S3 file system page, indicating that we do not test all S3-compatible storage systems

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@michaeleby1 michaeleby1 requested a review from mosabua July 22, 2024 16:56
@cla-bot cla-bot bot added the cla-signed label Jul 22, 2024
@github-actions github-actions bot added the docs label Jul 22, 2024
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principal but I think we might want to elaborate some more, depending on the technical feedback.

Comment thread docs/src/main/sphinx/object-storage/file-system-s3.md Outdated
@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added stale and removed stale labels Aug 13, 2024
Comment thread docs/src/main/sphinx/object-storage/file-system-s3.md Outdated
@electrum
Copy link
Copy Markdown
Member

I think we should remove this wording from the exchange manager documentation. It's very unlikely vendor documentation will tell the user about compatibility with Trino.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Aug 23, 2024

I think we should remove this wording from the exchange manager documentation. It's very unlikely vendor documentation will tell the user about compatibility with Trino.

Fair... maybe we should tell to check vendor docs and basically test themselves or something .. how do we want to guide users around the "S3-compatibility" from various systems when we just test with s3 and minio .. and even there we just use it in our testing but as open source project obviously dont offer "support"

@electrum
Copy link
Copy Markdown
Member

The user needs to test it themselves and contact the vendor with any questions.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Aug 26, 2024

The user needs to test it themselves and contact the vendor with any questions.

Ok .. can you reword it along those links here and in the exchange section @michaeleby1 .. and mention what Trino tests run with (S3 and minio) but there should be no perception of "support"

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit .. and also port these adjustments to the exchange manager section.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. I will merge after release completed.

@mosabua mosabua merged commit db4a2d5 into trinodb:master Aug 29, 2024
@github-actions github-actions bot added this to the 456 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants