Skip to content

Bump default value of max split count per task for FTE #22622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
Sep 2, 2024
Merged

Bump default value of max split count per task for FTE #22622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public class QueryManagerConfig
private int faultTolerantExecutionHashDistributionWriteTaskTargetMaxCount = 2000;

private DataSize faultTolerantExecutionStandardSplitSize = DataSize.of(64, MEGABYTE);
private int faultTolerantExecutionMaxTaskSplitCount = 256;
private int faultTolerantExecutionMaxTaskSplitCount = 2048;
private DataSize faultTolerantExecutionTaskDescriptorStorageMaxMemory = DataSize.ofBytes(round(AVAILABLE_HEAP_MEMORY * 0.15));
private int faultTolerantExecutionMaxPartitionCount = 50;
private int faultTolerantExecutionMinPartitionCount = 4;
Expand Down
2 changes: 1 addition & 1 deletion core/trino-main/src/test/java/io/trino/execution/TestQueryManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public void testDefaults()
.setFaultTolerantExecutionHashDistributionWriteTasksToNodesMinRatio(2.0)
.setFaultTolerantExecutionHashDistributionWriteTaskTargetMaxCount(2000)
.setFaultTolerantExecutionStandardSplitSize(DataSize.of(64, MEGABYTE))
.setFaultTolerantExecutionMaxTaskSplitCount(256)
.setFaultTolerantExecutionMaxTaskSplitCount(2048)
.setFaultTolerantExecutionTaskDescriptorStorageMaxMemory(DataSize.ofBytes(round(AVAILABLE_HEAP_MEMORY * 0.15)))
.setFaultTolerantExecutionMaxPartitionCount(50)
.setFaultTolerantExecutionMinPartitionCount(4)
Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/sphinx/admin/fault-tolerant-execution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ properties only apply to a `TASK` retry policy.
May be overridden for the current session with the
`fault_tolerant_execution_max_task_split_count` [session
property](session-properties-definition).
- `256`
- `2048`
* - `fault-tolerant-execution-arbitrary-distribution-compute-task-target-size-growth-period`
- The number of tasks created for any given non-writer stage of arbitrary
distribution before task size is increased.
Expand Down