Add date data type support for Kudu #22497
Merged
Praveen2112 merged 2 commits intotrinodb:masterfrom Jun 27, 2024
Merged
Conversation
Praveen2112
requested review from
ebyhr,
krvikash,
marcinsbd,
ssheikin and
vlad-lyutenko
Praveen2112
force-pushed
the
praveen/kudu_date_type
branch
from
0cd3f8f to
59e17ce
Compare
Praveen2112
force-pushed
the
praveen/kudu_date_type
branch
2 times, most recently
from
f7eebda to
501a81b
Compare
vlad-lyutenko
approved these changes
Jun 26, 2024
Praveen2112
force-pushed
the
praveen/kudu_date_type
branch
from
501a81b to
256772d
Compare
ssheikin
reviewed
Jun 26, 2024
ebyhr
approved these changes
Jun 27, 2024
Member
|
(Reviewed only last 2 commits) |
Inserting/Merging/Updating invalid data in Kudu doesn't throw a Kudu specific exception so we wrap all the exceptions as Trino specific exceptions
Co-authored-by: Pascal Gasp <pascal.gasp@gmail.com>
Praveen2112
force-pushed
the
praveen/kudu_date_type
branch
from
256772d to
592b751
Compare
Member
Author
|
@ebyhr Thanks for the review. AC |
Praveen2112
commented
Jun 27, 2024
marcinsbd
reviewed
Jun 27, 2024
marcinsbd
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously Date type was mapped to
VARCHARand Kudu has natively added supported forDATEfrom 1.15. This PR maps Kudu Date type to Trino's Date type.Partially fixes #11009
Additional context and related issues
This PR depends on #22496
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: