Use List/Set injection into configuration#22460
Merged
Conversation
This makes configuration more explicit in regard to expected types
09a4996 to
44a8277
Compare
Contributor
Author
|
Configuration classes should get expected types, rather than parsing them. This aligns better with the idea of introduction of alternate formats to Java properties (like TOML) |
losipiuk
reviewed
Jun 21, 2024
losipiuk
reviewed
Jun 21, 2024
losipiuk
reviewed
Jun 21, 2024
Member
losipiuk
left a comment
There was a problem hiding this comment.
Seems mostly fine - but not 100% backward compatible.
Contributor
Author
|
@losipiuk it is, string.toUpperCase was needed to call Enum.valueOf but this is handled by airlift. |
Contributor
Author
|
@losipiuk there are tests in both Trino and Airlift that are setting configuration properties mapped to enum with a lower case strings |
Member
|
ok |
losipiuk
approved these changes
Jun 21, 2024
Contributor
Author
|
@losipiuk i.e. here: as this maps to: |
Member
|
Does this need a release note? @wendigo |
Contributor
Author
|
@colebow no. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes configuration more explicit in regard to expected types. Mostly a cleanup
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: