Skip to content

Migrate identity column to integration tests in Delta#22448

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/delta-generated-column
Aug 30, 2024
Merged

Migrate identity column to integration tests in Delta#22448
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/delta-generated-column

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jun 20, 2024 •
edited
Loading

Description

Follows https://trino.io/docs/current/develop/tests.html#avoid-product-tests

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jun 20, 2024
@github-actions github-actions bot added the delta-lake Delta Lake connector label Jun 20, 2024
@ebyhr ebyhr force-pushed the ebi/delta-generated-column branch from 4e21f7a to 4402a68 Compare June 20, 2024 05:17
@ebyhr ebyhr requested review from findinpath, pajaks and wendigo June 21, 2024 03:18
pajaks
pajaks reviewed Jun 26, 2024
View reviewed changes
Comment thread ...n/trino-delta-lake/src/test/resources/databricks133/identity_columns_table_feature/README.md Outdated
Comment thread plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java Outdated
Comment thread plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java Outdated
SemionPar
SemionPar approved these changes Jul 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@SemionPar SemionPar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT % nit

Comment thread plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java Outdated
Comment thread plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java Outdated
Comment thread plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java Outdated
Comment thread ...n/trino-delta-lake/src/test/resources/databricks133/identity_columns_table_feature/README.md Outdated
Comment thread plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java Outdated
@github-actions github-actions bot added the stale label Aug 21, 2024
@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Aug 21, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Aug 21, 2024

I assume you will run with this @ebyhr

@trinodb trinodb deleted a comment from github-actions bot Aug 30, 2024
@ebyhr ebyhr force-pushed the ebi/delta-generated-column branch from 4402a68 to 9c2bb2f Compare August 30, 2024 01:40
@ebyhr ebyhr requested a review from raunaqmorarka August 30, 2024 01:40
@ebyhr ebyhr merged commit 6ac2abb into trinodb:master Aug 30, 2024
@ebyhr ebyhr deleted the ebi/delta-generated-column branch August 30, 2024 06:48
@github-actions github-actions bot added this to the 456 milestone Aug 30, 2024
@mosabua mosabua mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@wendigo wendigo Awaiting requested review from wendigo

+3 more reviewers

@SemionPar SemionPar SemionPar approved these changes

@findinpath findinpath findinpath approved these changes

@pajaks pajaks pajaks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed delta-lake Delta Lake connector stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.

Milestone

457

Development

Successfully merging this pull request may close these issues.

6 participants

@ebyhr @mosabua @raunaqmorarka @SemionPar @findinpath @pajaks