Skip to content

Make sure expression type does not change after processing with rule #22395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Make sure expression type does not change after processing with rule #22395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/trino-main/src/main/java/io/trino/sql/ir/optimizer/IrExpressionOptimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@
import java.util.Map;
import java.util.Optional;

import static com.google.common.base.Preconditions.checkState;

public class IrExpressionOptimizer
{
private final List<IrOptimizerRule> rules;
Expand Down Expand Up @@ -286,6 +288,12 @@ private Optional<Expression> applyRules(Expression expression, Session session,
for (IrOptimizerRule rule : rules) {
Optional<Expression> optimized = rule.apply(expression, session, bindings);
if (optimized.isPresent()) {
checkState(
expression.type().equals(optimized.get().type()),
"Rule %s changed expression type from %s to %s",
rule.getClass().getSimpleName(),
expression.type(),
optimized.get().type());
expression = optimized.get();
changed = true;
}
Expand Down