Maven cleanup #22382
Merged
Maven cleanup #22382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
jdbc
cstamas
approved these changes
Jun 13, 2024
Contributor
Author
|
Last commit to be dropped. |
Member
|
Agreed, on release this URL is going away. |
mosabua
approved these changes
Jun 13, 2024
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Looks good to me. If the new property is a clean replacement .. should we set the value of air.main.basedir to its value in upstream airlift/airbase ... or remove it complete in a follow up PR?
Contributor
Author
|
I'm not sure whether this will work that way but I'll follow-up :) |
wendigo
force-pushed
the
serafin/maven-improvements
branch
from
53d94c7 to
4b43eb0
Compare
Contributor
Author
Contributor
Author
|
@mosabua you can't set in the airbase - seems like a $session properties can't be used in the pom itself |
Contributor
Author
|
Updated to maven 3.9.8 |
cstamas
approved these changes
Jun 17, 2024
Member
cstamas
left a comment
cstamas
left a comment
There was a problem hiding this comment.
NB: 3.9.8 announce (and even mvn site update) is yet to happen
It's a default builder for mvnd
This version is aligned with mvnd-1.0.0
wendigo
force-pushed
the
serafin/maven-improvements
branch
from
42f0c4a to
7052d32
Compare
Contributor
Author
|
mvnd 1.0.0 now available on homebrew and sdkman - merging this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires new mvnd release for compatibility.
Tested with https://github.com/apache/maven-mvnd/actions/runs/9500170890
Works with mvn 3.9.7 (current) and 3.9.8 (being released right now).