Skip to content

Conversation

@nineinchnick
Copy link
Member

Description

Dependabot will automatically open pull requests to update GitHub Actions. The main benefit of this is knowing that new versions are available, especially if third-party GitHub Actions are pinned to specific versions. Running it weekly should give enough time to review updates, and also react swiftly to potential security updates.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Dependabot will automatically open pull requests to update GitHub
Actions. The main benefit of this is knowing that new versions are
available, especially if third-party GitHub Actions are pinned to
specific versions. Running it weekly should give enough time to review
updates, and also react switfly to potential security updates.
@findepi
Copy link
Member

findepi commented Jun 13, 2024

i'd like to have dependabot for normal dependencies even more than for actions.
That's because we don't ship action code, but we do ship the dependencies. Currently the whole burden is carried by @wendigo , but that feels unfair.

@nineinchnick
Copy link
Member Author

I agree we should be using Dependabot instead of checking updates manually, but we need to configure it with access to secrets, so only an admin can do this.

@findepi
Copy link
Member

findepi commented Jun 13, 2024

I agree we should be using Dependabot instead of checking updates manually, but we need to configure it with access to secrets, so only an admin can do this.

@martint asked me this question -- Does dependabot understand the relationship between trino and airbase?

@nineinchnick do you maybe know?

@nineinchnick
Copy link
Member Author

Does dependabot understand the relationship between trino and airbase?

You mean does it understand parent projects, or the usage of proeprties? Would it be better to discuss this on Slack? It's out of the scope of this PR.

@nineinchnick
Copy link
Member Author

I've been using it in all my third-party Trino plugin repositories, check out this PR as an example: nineinchnick/trino-git#192

@mosabua
Copy link
Member

mosabua commented Jun 13, 2024

I agree that this will be useful but I am also worried this is going to be noisy. Who is going to take on looking at all the PRs and evaluating them towards merge?

@wendigo
Copy link
Contributor

wendigo commented Jun 13, 2024

@mosabua it's scheduled weekly so shouldn't bring too much noise

@mosabua
Copy link
Member

mosabua commented Jun 13, 2024

@mosabua it's scheduled weekly so shouldn't bring too much noise

Lets hope so .. we can always tweak it as well. We might want to decide how we want to deal with the commit messages .. always squash and merge with rewording?

@wendigo
Copy link
Contributor

wendigo commented Jun 13, 2024

@mosabua let's merge it and see the quality of PR and we can always revert

@mosabua
Copy link
Member

mosabua commented Jun 13, 2024

Also note.. a bunch of this discussion is more about actual dependencies vs just the versions of the github actions .. but I am supportive of both..

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @wendigo .. ship it.

@wendigo wendigo merged commit a2558e5 into trinodb:master Jun 13, 2024
@github-actions github-actions bot added this to the 450 milestone Jun 13, 2024
@nineinchnick nineinchnick deleted the dependabot branch September 26, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants