-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Enable Dependabot for GitHub Actions #22378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dependabot will automatically open pull requests to update GitHub Actions. The main benefit of this is knowing that new versions are available, especially if third-party GitHub Actions are pinned to specific versions. Running it weekly should give enough time to review updates, and also react switfly to potential security updates.
|
i'd like to have dependabot for normal dependencies even more than for actions. |
|
I agree we should be using Dependabot instead of checking updates manually, but we need to configure it with access to secrets, so only an admin can do this. |
@martint asked me this question -- Does dependabot understand the relationship between trino and airbase? @nineinchnick do you maybe know? |
You mean does it understand parent projects, or the usage of proeprties? Would it be better to discuss this on Slack? It's out of the scope of this PR. |
|
I've been using it in all my third-party Trino plugin repositories, check out this PR as an example: nineinchnick/trino-git#192 |
|
I agree that this will be useful but I am also worried this is going to be noisy. Who is going to take on looking at all the PRs and evaluating them towards merge? |
|
@mosabua it's scheduled weekly so shouldn't bring too much noise |
Lets hope so .. we can always tweak it as well. We might want to decide how we want to deal with the commit messages .. always squash and merge with rewording? |
|
@mosabua let's merge it and see the quality of PR and we can always revert |
|
Also note.. a bunch of this discussion is more about actual dependencies vs just the versions of the github actions .. but I am supportive of both.. |
mosabua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @wendigo .. ship it.
Description
Dependabot will automatically open pull requests to update GitHub Actions. The main benefit of this is knowing that new versions are available, especially if third-party GitHub Actions are pinned to specific versions. Running it weekly should give enough time to review updates, and also react swiftly to potential security updates.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: