Add session properties for prometheus connector #22368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitkharb
force-pushed
the
22319
branch
2 times, most recently
from
e335e3f
to
afaea47
Compare
github-actions
bot
added
docs
hudi
amitkharb
removed
hudi
github-actions
bot
added
jdbc
amitkharb
removed
jdbc
|
@ebyhr , could you please have a look, I have added the reason for session properties in the description and updated the branch to latest. Thank you |
ebyhr
reviewed
Jul 22, 2024
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusConnector.java
Show resolved
Hide resolved
...n/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSessionProperties.java
Outdated
Show resolved
Hide resolved
...n/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSessionProperties.java
Show resolved
Hide resolved
...n/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSplitManager.java
Outdated
Show resolved
Hide resolved
...ino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusSessionProperties.java
Outdated
Show resolved
Hide resolved
amitkharb
changed the title
ebyhr
reviewed
Jul 30, 2024
...n/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSessionProperties.java
Outdated
Show resolved
Hide resolved
...n/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSessionProperties.java
Outdated
Show resolved
Hide resolved
|
@ebyhr , please have a look, indentation is fixed. Thank you |
ebyhr
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Please follow the commit message guideline: https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
Adding session properties for prometheus connector
Sizes of different metrics may differ, to run automated ETL pipelines efficiently we can set different values of session properties like query_chunk_size_duration and max_query_range_duration.
Adding ... should be changed to Add .... Also, please wrap the commit body at 72 characters.
...n/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSessionProperties.java
Show resolved
Hide resolved
...n/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSessionProperties.java
Outdated
Show resolved
Hide resolved
|
@ebyhr , could you please have look at the changes. thank you |
ebyhr
reviewed
Aug 13, 2024
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusIntegration.java
Outdated
Show resolved
Hide resolved
amitkharb
changed the title
ebyhr
approved these changes
Aug 22, 2024
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusIntegration.java
Outdated
Show resolved
Hide resolved
|
@ebyhr , I will addd a TODO comment and also removed the testSessionProperties. |
Size of different metrics may differ hence adding the session properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the session properties support for Prometheus Connector.
Additional context and related issues
Sizes of different metrics may differ, to run automated ETL pipelines efficiently we can set different values of session properties like query_chunk_size_duration and max_query_range_duration.
Fixes #22319
Release notes
() This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
() Release notes are required, with the following suggested text: