Fix failure when reading non-primitive Parquet fields in Iceberg #22367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/icebeg-parquet-field-id
branch
from
b9bf1f1 to
65b84b1
Compare
findepi
approved these changes
Jun 12, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/icebeg-parquet-field-id
branch
from
65b84b1 to
0cc9025
Compare
ebyhr
force-pushed
the
ebi/icebeg-parquet-field-id
branch
from
0cc9025 to
73e589c
Compare
raunaqmorarka
approved these changes
Jun 12, 2024
Heltman
approved these changes
Jun 12, 2024
wendigo
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were getting the value from
descriptorsByPathonly when it's a primitive type before #19066.Fixes #22347
Release notes