Skip to content

Conversation

@Praveen2112
Copy link
Member

@Praveen2112 Praveen2112 commented Jun 6, 2024

Description

This PR adds support for char to varchar coercion for partitioned table.

Depends on #22293.

Comes under #19643.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Hive
* Allow char to varchar coercion for hive tables

@cla-bot cla-bot bot added the cla-signed label Jun 6, 2024
@github-actions github-actions bot added iceberg Iceberg connector hive Hive connector labels Jun 6, 2024
@Praveen2112 Praveen2112 force-pushed the praveen/updated_char_to_varchar_coercion branch 3 times, most recently from c8aa48d to bba95ac Compare June 7, 2024 07:28
@Praveen2112 Praveen2112 force-pushed the praveen/updated_char_to_varchar_coercion branch from bba95ac to a9e2961 Compare June 7, 2024 07:42
@github-actions github-actions bot added the docs label Jun 7, 2024
@raunaqmorarka
Copy link
Member

This is implementing support only for partitioned column right ? I think it already works in orc/parquet

@Praveen2112
Copy link
Member Author

yes - I have the PR description. We have added test for both partitioned and un-partitioned tables (ORC and Parquet)

@Praveen2112 Praveen2112 merged commit 2cd89ce into trinodb:master Jun 7, 2024
@github-actions github-actions bot added this to the 450 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed docs hive Hive connector iceberg Iceberg connector

Development

Successfully merging this pull request may close these issues.

5 participants