fix open lineage runtime failure with HTTP transport #22228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Jun 2, 2024
ebyhr
reviewed
Jun 2, 2024
The dependency is required for openlineage-java.
ebyhr
force-pushed
the
fix-ol-http-transport
branch
from
8681d42 to
a2668ac
Compare
findepi
reviewed
Jun 20, 2024
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <scope>runtime</scope> |
Member
There was a problem hiding this comment.
Typically runtime dependencies are not needed. So ideally there could be a code comment saying why this one is needed. BTW the fact we need to manually add this is an effect of incorrect exclude somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenLineage event listener fails to initialize with HTTP transport
Additional context and related issues
This event listener depends on openlineage-java which depends on org.apache.commons.lang3.StringUtils. However there is no runtime dependency defined on
commons.lang3, hence it is failing in runtime.It is working on the Test because we have a test scope dependency on testcontainers which pulls
commons.lang3(see the truncated test dependency tree below)Release notes
( ) Release notes are required, with the following suggested text: