Use hive.metastore of JVM options in DeltaLakeExternalQueryRunnerMain #22088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
May 23, 2024
| // Please set Delta Lake connector properties via VM options. e.g. -Dhive.metastore=glue -D.. | ||
| QueryRunner queryRunner = builder() | ||
| .addCoordinatorProperty("http-server.http.port", "8080") | ||
| .addDeltaProperty("hive.metastore", System.getProperty("hive.metastore")) |
Member
There was a problem hiding this comment.
Per the code comment above, this supposedly already work for this property and others.
BTW I think we should consider deleting the DeltaLakeExternalQueryRunnerMain class. One can use development server with custom delta.properties for the same purpose.
Member
Author
There was a problem hiding this comment.
It was working until ddf931f
I prefer this query runner to development server because it doesn't require rebuild after changed the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We could specify metastore type with JVM options before ddf931f.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.