Improve speed when bigquery.case-insensitive-name-matching is enabled #22033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
May 20, 2024
hashhar
approved these changes
May 20, 2024
nineinchnick
approved these changes
May 20, 2024
Member
Author
|
|
ebyhr
commented
May 21, 2024
| public void createSchema(DatasetInfo datasetInfo) | ||
| { | ||
| bigQuery.create(datasetInfo); | ||
| remoteDatasetIdCache.invalidate(datasetInfo.getDatasetId().getProject()); |
Member
Author
There was a problem hiding this comment.
@wendigo @hashhar @nineinchnick I pushed another small commit. Could you please take another look?
nineinchnick
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invalidate remoteDatasetIdCache when after creating or dropping a schema.
This PR improves
SHOW SCHEMASspeed 60 seconds → ~1 second with 75 schemas.Release notes
(x) Release notes are required, with the following suggested text: