Merged
Conversation
findepi
reviewed
Dec 5, 2019
presto-main/src/main/java/io/prestosql/server/InternalAuthenticationManager.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Dec 5, 2019
presto-main/src/main/java/io/prestosql/server/InternalAuthenticationManager.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
internal-jwt-default
branch
from
ea6f440 to
64357c1
Compare
dain
force-pushed
the
internal-jwt-default
branch
3 times, most recently
from
b93bfef to
0e27e27
Compare
dain
force-pushed
the
internal-jwt-default
branch
from
0e27e27 to
0ee940f
Compare
electrum
approved these changes
Feb 2, 2020
presto-main/src/main/java/io/prestosql/server/InternalAuthenticationManager.java
Outdated
Show resolved
Hide resolved
presto-docs/src/main/sphinx/security/internal-communication.rst
Outdated
Show resolved
Hide resolved
presto-docs/src/main/sphinx/security/internal-communication.rst
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/server/InternalAuthenticationManager.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Should this be marked as legacy/deprecated? Is there a use case to turn this off? Maybe for debugging? If so, perhaps name it something like internal-communication.jwt.disabled-for-testing
(we can merge this as-is for now and follow up later)
Internal security always uses a shared secret
dain
force-pushed
the
internal-jwt-default
branch
from
0ee940f to
e5c06dc
Compare
nmahadevuni
added a commit
to nmahadevuni/presto
that referenced
this pull request
Jun 16, 2023
Supports JWT for authentication of internal requests. This is required for secure internal communication, especially when used in conjunction with external user authentication such as PASSWORD, LDAP etc Cherry-pick of trinodb/trino#2032 Cherry-pick of trinodb/trino#2090 Cherry-pick of trinodb/trino#2093 Cherry-pick of trinodb/trino#2202 Cherry-pick of trinodb/trino#11944 Co-authored-by: Dain Sundstrom <dain@iq80.com>
tdcmeehan
pushed a commit
to prestodb/presto
that referenced
this pull request
Jun 22, 2023
Supports JWT for authentication of internal requests. This is required for secure internal communication, especially when used in conjunction with external user authentication such as PASSWORD, LDAP etc Cherry-pick of trinodb/trino#2032 Cherry-pick of trinodb/trino#2090 Cherry-pick of trinodb/trino#2093 Cherry-pick of trinodb/trino#2202 Cherry-pick of trinodb/trino#11944 Co-authored-by: Dain Sundstrom <dain@iq80.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.