Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented May 13, 2024

I don't know why it was excluded in the first place.

(base) ➜  trino git:(serafin/do-not-exclude-protobuf) ✗ ./mvnw dependency:tree -pl ':trino-exchange-filesystem' | grep protobuf
[INFO] |  +- com.google.protobuf:protobuf-java:jar:3.25.3:compile
[INFO] |  +- com.google.protobuf:protobuf-java-util:jar:3.25.3:compile
[INFO] |  +- io.grpc:grpc-protobuf:jar:1.62.2:compile
[INFO] |  +- io.grpc:grpc-protobuf-lite:jar:1.62.2:runtime
(base) ➜  trino git:(serafin/do-not-exclude-protobuf) ✗ git checkout master
Switched to branch 'master'
Your branch is ahead of 'origin/master' by 25 commits.
  (use "git push" to publish your local commits)
(base) ➜  trino git:(master) ✗ ./mvnw dependency:tree -pl ':trino-exchange-filesystem' | grep protobuf
[INFO] |  +- com.google.protobuf:protobuf-java-util:jar:3.25.3:compile
[INFO] |  +- io.grpc:grpc-protobuf:jar:1.62.2:compile
[INFO] |  +- io.grpc:grpc-protobuf-lite:jar:1.62.2:runtime

Release note: Fix startup failure when FTE is enabled with GCS exchange

It's actually needed for GCS to work
@cla-bot cla-bot bot added the cla-signed label May 13, 2024
@wendigo wendigo requested review from findepi and losipiuk May 13, 2024 09:27
@wendigo wendigo merged commit 15a1338 into master May 13, 2024
@wendigo wendigo deleted the serafin/do-not-exclude-protobuf branch May 13, 2024 10:48
@github-actions github-actions bot added this to the 448 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants