Minor cleanups in parquet #21948
Merged
Minor cleanups in parquet #21948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
May 13, 2024
Upgrade to new parquet-mr includes the necessary fixes
This class no longer uses Unsafe methods from Slice
raunaqmorarka
force-pushed
the
pqr-cleanup
branch
from
d074109 to
8594b88
Compare
sopel39
approved these changes
May 13, 2024
sopel39
reviewed
May 13, 2024
| ImmutableMultiset.<CacheOperation>builder() | ||
| .add(new CacheOperation("Alluxio.readCached", "00000000000000000000.json", 0, 757)) | ||
| .add(new CacheOperation("Alluxio.readCached", "00000000000000000001.json", 0, 636)) | ||
| .add(new CacheOperation("Alluxio.readCached", "00000000000000000002.json", 0, 636)) |
Member
Author
There was a problem hiding this comment.
started populating 2 new fields is_exact_min/max in the parquet footer
sopel39
reviewed
May 13, 2024
| } | ||
|
|
||
| /** | ||
| * Always check if needed data is available with ensureBytesAvailable method. |
Member
There was a problem hiding this comment.
Is the comment no longer viable? Maybe remove suffix unchecked then?
Member
Author
There was a problem hiding this comment.
suffix unchecked is copied from Slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor cleanups in parquet
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: