Migrate Glue/S3 tests to AWS SDK v2 #21918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/table-not-found
branch
2 times, most recently
from
4b01503 to
f1bfeb0
Compare
findepi
changed the title
github-actions
bot
added
iceberg
findepi
force-pushed
the
findepi/table-not-found
branch
2 times, most recently
from
98c1ae2 to
192e0dc
Compare
findepi
requested review from
charlesjmorgan,
ebyhr,
electrum,
findinpath and
pajaks
losipiuk
approved these changes
May 10, 2024
findepi
force-pushed
the
findepi/table-not-found
branch
from
192e0dc to
1b954f9
Compare
The test uses explicit schema location, so there is no schema name "escaping" for construction of S3 locations. Rename the test. Add a new one matching the supposed meaning.
And hide the other one. Factory method should be used instead.
findepi
force-pushed
the
findepi/table-not-found
branch
5 times, most recently
from
6d240db to
1f811ed
Compare
findepi
force-pushed
the
findepi/table-not-found
branch
from
1f811ed to
68da5ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #21917