-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add timeout for setup step #21762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout for setup step #21762
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
CLA sent, just waiting for it to be processed. |
|
Here's some data around the duration of these steps in the last 7 days:
All steps: The query: select
r.name as workflow_name
, s.name as step_name
, count(*) as num_records
, avg(s.completed_at - s.started_at) filter (where r.head_branch = 'master') as avg_step_duration_master
, max(s.completed_at - s.started_at) filter (where r.head_branch = 'master') as max_step_duration_master
, avg(s.completed_at - s.started_at) as avg_step_duration
, max(s.completed_at - s.started_at) as max_step_duration
from steps s
join runs r on (r.owner, r.repo, r.id) = (s.owner, s.repo, s.run_id)
where s.owner = 'trinodb' and s.repo = 'trino'
and r.owner = 'trinodb' and r.repo = 'trino'
and s.started_at > current_date - interval '7' day
group by 1, 2
order by 1, 2
; |
|
@clabot recheck |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
Description
Set a distinct timeout just for the setup phase. It should either finish in few minutes or fail, no need to wait 1 hour (a timeout for the jobs).
Additional context and related issues
I have seen at least twice this week that a test lane failed during setup. It failed while trying to recreate cache. Might be a network problem, no idea.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: