Write checkpoint if necessary for CREATE OR REPLACE statements #21609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
from
346ea1c to
40df1d3
Compare
findinpath
reviewed
Apr 19, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
from
40df1d3 to
c100560
Compare
belen-pruvost
changed the title
create or replace statements for existing tables
findinpath
reviewed
Apr 19, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Outdated
Show resolved
Hide resolved
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
from
c100560 to
0878304
Compare
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
3 times, most recently
from
4283234 to
4210391
Compare
findinpath
reviewed
Apr 25, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java
Outdated
Show resolved
Hide resolved
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Outdated
Show resolved
Hide resolved
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Outdated
Show resolved
Hide resolved
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
from
4210391 to
0d6124a
Compare
findinpath
reviewed
Apr 25, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Apr 25, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Apr 25, 2024
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Apr 25, 2024
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Apr 25, 2024
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Apr 25, 2024
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Outdated
Show resolved
Hide resolved
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
4 times, most recently
from
63197e9 to
6bc3c31
Compare
findinpath
reviewed
Apr 26, 2024
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
2 times, most recently
from
5b97d81 to
e704950
Compare
findinpath
reviewed
Apr 26, 2024
Contributor
There was a problem hiding this comment.
do we need here as well the check to see whether the table existed before?
Member
Author
There was a problem hiding this comment.
I think it may be redundant considering that on line 968
boolean replaceExistingTable = tableHandle != null && saveMode == SaveMode.REPLACE;
and that we know it exists in that scenario, as we then do this on line 970
ConnectorTableMetadata existingTableMetadata = getTableMetadata(session, tableHandle);
findinpath
approved these changes
Apr 26, 2024
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
from
e704950 to
ea53815
Compare
Member
Author
|
We implemented a similar change to this on top of our Trino fork on April 19th, as we have multiple tables being queried that are created via |
belen-pruvost
force-pushed
the
write-checkpoint-on-replace
branch
from
ea53815 to
b43e4ae
Compare
ebyhr
reviewed
May 13, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
approved these changes
May 13, 2024
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Looks good except for https://github.com/trinodb/trino/pull/21609/files#r1597977836
ebyhr
force-pushed
the
write-checkpoint-on-replace
branch
from
b43e4ae to
5382bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
CREATE [OR REPLACE] TABLEstatements for an existing table, thefinishCreatemethod is currently not writing a checkpoint to the Delta Log. This PR makes it possible to write those checkpoints. It results in faster analysis times for queries that read from those tables.Additional context and related issues
We have noticed that tables recreated through this flow (
CREATE [OR REPLACE] TABLE) have more than 2000 commits and no checkpoint, which leads to a very bad analysis timeRelease notes
(x) This is not user-visible or is docs only, and no release notes are required.