Skip to content

Add .editorconfig#2151

Merged
findepi merged 1 commit intotrinodb:masterfrom
findepi:editorconfig
Dec 11, 2019
Merged

Add .editorconfig#2151
findepi merged 1 commit intotrinodb:masterfrom
findepi:editorconfig

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Nov 29, 2019

No description provided.

@cla-bot cla-bot Bot added the cla-signed label Nov 29, 2019
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Nov 29, 2019

Currently my IntelliJ ignores indent_size for .sh files (it works for .java), so we still need airlift/codestyle#9

@electrum
Copy link
Copy Markdown
Member

Why do we need this? Is this for IntelliJ (and if so does code style not cover it) or something else?

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Nov 30, 2019

For IntelliJ.

Comment thread .editorconfig Outdated
@electrum
Copy link
Copy Markdown
Member

electrum commented Dec 9, 2019

We could add this as well:

[*]
trim_trailing_whitespace = true
indent_style = space
indent_size = 4

[*.md]
trim_trailing_whitespace = false

I don't think we use a different indent size elsewhere, but we could override if we do.

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Dec 10, 2019

AC

@findepi findepi assigned electrum and unassigned findepi Dec 10, 2019
@findepi findepi merged commit cd6c18a into trinodb:master Dec 11, 2019
@findepi findepi deleted the editorconfig branch December 11, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants