Check table existence in Trino instead of Cassandra #21504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Apr 11, 2024
hashhar
reviewed
Apr 15, 2024
|
|
||
| // Ensure that the currently created table is visible to other sessions (e.g. the session used in DistributedQueryRunner) | ||
| server.refreshSizeEstimates(keyspace, tableName); | ||
| // Ensure that the currently created table is visible to Trino |
Member
There was a problem hiding this comment.
was this flaky because of the default of cassandra.consistency-level being ONE instead of QUORUM?
Member
Author
There was a problem hiding this comment.
The flaky issue still remains with QUORUM as far as I confirmed locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stress test result of TestCassandraConnectorTest#testTimestampPartitionKey
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.