Use ThreadLocalRecyclerPool for Jackson #21361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Apr 2, 2024
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/util/JsonUtils.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/jackson-recycler
branch
from
bdf099d to
054a199
Compare
findepi
reviewed
Apr 2, 2024
| // due to the limits introduced by Jackson 2.15 | ||
| public static JsonFactoryBuilder jsonFactoryBuilder() | ||
| { | ||
| // https://github.com/FasterXML/jackson-core/issues/1256 |
Member
There was a problem hiding this comment.
it is weird that the link to FasterXML/jackson-core#1256 is not next to the line with recyclerPool.
is this really what you wanted @electrum in #21361 (comment) ?
losipiuk
approved these changes
Apr 2, 2024
Contributor
Author
|
I have no opinion on the comment location and which is better. In the end it matters less than a change itself. Therefore merging as-is, improvements are welcome |
mosabua
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.