Skip to content

Fix JsonProperty annotation in Iceberg #21321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Fix JsonProperty annotation in Iceberg #21321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMergeTableHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ public class IcebergMergeTableHandle
private final IcebergWritableTableHandle insertTableHandle;

@JsonCreator
public IcebergMergeTableHandle(IcebergTableHandle tableHandle, IcebergWritableTableHandle insertTableHandle)
public IcebergMergeTableHandle(
@JsonProperty("tableHandle") IcebergTableHandle tableHandle,
@JsonProperty("insertTableHandle") IcebergWritableTableHandle insertTableHandle)
{
this.tableHandle = requireNonNull(tableHandle, "tableHandle is null");
this.insertTableHandle = requireNonNull(insertTableHandle, "insertTableHandle is null");
Expand Down
4 changes: 2 additions & 2 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergWritableTableHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ public class IcebergWritableTableHandle
public IcebergWritableTableHandle(
@JsonProperty("name") SchemaTableName name,
@JsonProperty("schemaAsJson") String schemaAsJson,
@JsonProperty("partitionSpecsAsJson") Map<Integer, String> partitionsSpecsAsJson,
@JsonProperty("partitionsSpecsAsJson") Map<Integer, String> partitionsSpecsAsJson,
@JsonProperty("partitionSpecId") int partitionSpecId,
@JsonProperty("sortOrder") List<TrinoSortField> sortOrder,
@JsonProperty("inputColumns") List<IcebergColumnHandle> inputColumns,
@JsonProperty("outputPath") String outputPath,
@JsonProperty("fileFormat") IcebergFileFormat fileFormat,
@JsonProperty("properties") Map<String, String> storageProperties,
@JsonProperty("storageProperties") Map<String, String> storageProperties,
@JsonProperty("retryMode") RetryMode retryMode,
@JsonProperty("fileIoProperties") Map<String, String> fileIoProperties)
{
Expand Down