Skip to content

Migrate kinesis connector to use AWS SDK v2#21314

Closed
wendigo wants to merge 1 commit intomasterfrom
kinesis-sdk-v2-master
Closed

Migrate kinesis connector to use AWS SDK v2#21314
wendigo wants to merge 1 commit intomasterfrom
kinesis-sdk-v2-master

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented Mar 28, 2024

Taking over #18290

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Seems like CI passes mostly too, although .. we dont have a test suite for Kinesis or it didnt run or I just dont see it. From my perspective .. ship it anyway if it passes for you locally.

@wendigo wendigo force-pushed the kinesis-sdk-v2-master branch from b5e93eb to bb18885 Compare March 28, 2024 18:24
Co-authored-by: Karan Makhija <karanmakhija867@gmail.com>
@wendigo wendigo force-pushed the kinesis-sdk-v2-master branch from bb18885 to 34556df Compare March 28, 2024 19:22
@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Apr 19, 2024
@wendigo wendigo closed this Apr 23, 2024
@wendigo wendigo deleted the kinesis-sdk-v2-master branch April 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants