Support installing only Temurin releases in product tests #21306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
Mar 28, 2024
...uct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/EnvironmentOptions.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/jdk-temurin-cleanup
branch
from
5140201 to
ab768ff
Compare
There is no point in keeping the existing code extensible as we only test with Temurin releases. Instead of adding new class representing a given Temurin release, allow passing a --trino-jdk-version that is now interpreted as Temurin release name. This supports both GA and EA builds. For consistency by default the same release is used as installed in the Docker image.
losipiuk
approved these changes
Mar 28, 2024
wendigo
force-pushed
the
serafin/jdk-temurin-cleanup
branch
from
ab768ff to
16cf859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use any other distribution rather then Temurin so there is no point in keeping this extensible. Instead of adding new JdkProvider implementation for every Temurin release, pass temurin release name and use generic logic to fetch it.