Add some FTE scheduler statistics #21292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekimir
approved these changes
Mar 27, 2024
findepi
approved these changes
Mar 28, 2024
Member
There was a problem hiding this comment.
will mbeanExporter unexport this later?
is this a problem in tests executing concurrently?
Member
Author
There was a problem hiding this comment.
will mbeanExporter unexport this later?
Are we unexporting jmx ever? If we do I would expect it will unexport these at same time we unexport others. But it would be at app shutdown anyway - so does not matter I think.
is this a problem in tests executing concurrently?
If we depended on stats in tests - probably yeah - it would cause issues. But we do not.
Member
There was a problem hiding this comment.
how many different outputEstimationKind values there are? <10, right?
Member
Author
There was a problem hiding this comment.
Yeah a couple right now. Don't expect the number to grow significantly
...trino-main/src/main/java/io/trino/execution/scheduler/faulttolerant/StageExecutionStats.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/fte-scheduler-observability
branch
from
14c9e17 to
494387e
Compare
losipiuk
force-pushed
the
lo/fte-scheduler-observability
branch
from
494387e to
9d7042b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: