Skip to content

Enable Snowflake testAddNotNullColumn test #21278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Enable Snowflake testAddNotNullColumn test #21278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...n/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestSnowflakeConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,10 @@ public void testShowCreateTable()
")");
}

@Test
@Override
public void testAddNotNullColumn()
protected void verifyAddNotNullColumnToNonEmptyTableFailurePermissible(Throwable e)
{
assertThatThrownBy(super::testAddNotNullColumn)
.isInstanceOf(AssertionError.class)
.hasMessage("Unexpected failure when adding not null column");
assertThat(e).hasMessageMatching("SQL compilation error: Non-nullable column .* cannot be added to non-empty table .* unless it has a non-null default value.");
}

@Test
Expand Down