Skip to content

Remove redundant clone method #21255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Remove redundant clone method #21255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7725c92
Mark the immutable class final
findepi Mar 26, 2024
36839b8
Remove redundant clone method
findepi Mar 26, 2024
69219ff
empty: roll the dice 🎲
findepi Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/execution/resourcegroups/InternalResourceGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ public Collection<InternalResourceGroup> subGroups()
ResourceUsage getResourceUsageSnapshot()
{
synchronized (root) {
return cachedResourceUsage.clone();
return cachedResourceUsage;
}
}

Expand Down
8 changes: 1 addition & 7 deletions core/trino-main/src/main/java/io/trino/execution/resourcegroups/ResourceUsage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import static com.google.common.math.LongMath.saturatedSubtract;

@Immutable
class ResourceUsage
final class ResourceUsage
{
private final long cpuUsageMillis;
private final long memoryUsageBytes;
Expand All @@ -32,12 +32,6 @@ public ResourceUsage(long cpuUsageMillis, long memoryUsageBytes)
this.memoryUsageBytes = memoryUsageBytes;
}

@Override
public ResourceUsage clone()
{
return new ResourceUsage(cpuUsageMillis, memoryUsageBytes);
}

public ResourceUsage add(ResourceUsage other)
{
long newCpuUsageMillis = saturatedAdd(this.cpuUsageMillis, other.cpuUsageMillis);
Expand Down