-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid populating _schema if the collection is empty in MongoDB connector #21236
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Mithilesh Wachasunder.
|
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
Show resolved
Hide resolved
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Mithilesh Wachasunder.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Mithilesh Wachasunder.
|
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
👋 @build2create - are you still interested in progressing this PR? If yes, could you address the comments from @ebyhr and fix any build failures? |
Yes sorry its been a while will resume on this. Based on the offline chat with @ebyhr seems like a different behaviour with Mongo Compass and Java Client so the test results are different. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
I think @build2create and @ebyhr are going to continue here .. even if slowly. So I am adding the stale-ignore label. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Co-Authored-By: build2create <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test in follow-up once we find a way to simulate the scenario with Java client.
Description
This PR is to fix the [issue][1]. Whenever a empty collection was created an entry was populated in default collection
_schema
. Further upon populating the collection with documents the fields in_schema
remained empty. So a workaround there is a check introduced to avoid populating_schema
if collection is empty.Fixes #20972
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.