Skip to content

Enable numeric aggregation pushdown test for Snowflake connector #21230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Enable numeric aggregation pushdown test for Snowflake connector #21230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfa5af2
Enable numeric aggregation pushdown test for Snowflake connector
chenjian2664 Mar 25, 2024
a1212e2
Rename method in SnowflakeClient
ebyhr Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public SnowflakeClient(
.add(new ImplementCountAll(bigintTypeHandle))
.add(new ImplementCount(bigintTypeHandle))
.add(new ImplementMinMax(false))
.add(new ImplementSum(SnowflakeClient::toTypeHandle))
.add(new ImplementSum(SnowflakeClient::decimalTypeHandle))
.add(new ImplementAvgFloatingPoint())
.add(new ImplementAvgDecimal())
.add(new ImplementAvgBigint())
Expand Down Expand Up @@ -267,9 +267,15 @@ public boolean supportsAggregationPushdown(ConnectorSession session, JdbcTableHa
return preventTextualTypeAggregationPushdown(groupingSets);
}

private static Optional<JdbcTypeHandle> toTypeHandle(DecimalType decimalType)
private static Optional<JdbcTypeHandle> decimalTypeHandle(DecimalType decimalType)
{
return Optional.of(new JdbcTypeHandle(Types.NUMERIC, Optional.of("decimal"), Optional.of(decimalType.getPrecision()), Optional.of(decimalType.getScale()), Optional.empty(), Optional.empty()));
return Optional.of(new JdbcTypeHandle(
Types.NUMERIC,
Optional.of("NUMBER"),
Optional.of(decimalType.getPrecision()),
Optional.of(decimalType.getScale()),
Optional.empty(),
Optional.empty()));
}

@Override
Expand Down
7 changes: 0 additions & 7 deletions ...n/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestSnowflakeConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,6 @@ public void testDistinctAggregationPushdown()
abort("TODO");
}

@Test
@Override
public void testNumericAggregationPushdown()
{
abort("TODO");
}

@Test
@Override
public void testInsertIntoNotNullColumn()
Expand Down